Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the model #401

Merged
merged 38 commits into from
Jun 22, 2023
Merged

Conversation

bruAristimunha
Copy link
Collaborator

@bruAristimunha bruAristimunha commented Jun 19, 2023

In this pull request we did a lot of things. Added save option for pytorch, keras and traditional pipeline. We fixed an issue with parallelization that is not using thread behavior, and was causing complications when running on some computers.

The new save is consistent and has testing for new code coverage.

@bruAristimunha bruAristimunha requested a review from carraraig June 19, 2023 17:35
@bruAristimunha
Copy link
Collaborator Author

It will fail in the tests

Copy link
Collaborator

@carraraig carraraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged

@bruAristimunha
Copy link
Collaborator Author

bruAristimunha commented Jun 21, 2023

TO-DO Bruno:
[x]: new tests, please!

@bruAristimunha
Copy link
Collaborator Author

Feel free to apply the merge when everything turns green @carraraig!

@carraraig
Copy link
Collaborator

Thanks @bruAristimunha !

@carraraig carraraig merged commit 2b38df2 into NeuroTechX:develop Jun 22, 2023
@bruAristimunha bruAristimunha deleted the saving_the_model branch June 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants